[U-Boot] [PATCH 01/30] x86: Add debugging when a microcode update fails

[Heiko Schocher]

Hello Simon,

Am 26.07.2016 um 02:58 schrieb Simon Glass:
> Add a debug() at this point to help figure out what is wrong.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   arch/x86/cpu/intel_common/cpu.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Heiko Schocher<hs at denx.de>

but wondering why this is in the "binman: A tool for creating firmware images"
series.

bye,
Heiko
>
> diff --git a/arch/x86/cpu/intel_common/cpu.c b/arch/x86/cpu/intel_common/cpu.c
> index 0fdef6f..ae42095 100644
> --- a/arch/x86/cpu/intel_common/cpu.c
> +++ b/arch/x86/cpu/intel_common/cpu.c
> @@ -42,8 +42,10 @@ int cpu_common_init(void)
>   	enable_lapic();
>
>   	ret = microcode_update_intel();
> -	if (ret && ret != -EEXIST)
> +	if (ret && ret != -EEXIST) {
> +		debug("%s: Microcode update failure (err=%d)\n", __func__, ret);
>   		return ret;
> +	}
>
>   	/* Enable upper 128bytes of CMOS */
>   	writel(1 << 2, RCB_REG(RC));
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany