[U-Boot] [PATCH 23/30] binman: Introduce binman, a tool for building binary images

[Heiko Schocher]

Hello Simon,

Am 26.07.2016 um 02:59 schrieb Simon Glass:
> This adds the basic code for binman, including command parsing, processing
> of entries and generation of images.
>
> So far no entry types are supported. These will be added in future commits
> as examples of how to add new types.
>
> See the README for documentation.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   tools/binman/.gitignore     |   1 +
>   tools/binman/README         | 491 ++++++++++++++++++++++++++++++++++++++++++++
>   tools/binman/binman         |   1 +
>   tools/binman/binman.py      |  96 +++++++++
>   tools/binman/cmdline.py     |  48 +++++
>   tools/binman/control.py     | 106 ++++++++++
>   tools/binman/etype/entry.py | 186 +++++++++++++++++
>   tools/binman/image.py       | 233 +++++++++++++++++++++
>   8 files changed, 1162 insertions(+)
>   create mode 100644 tools/binman/.gitignore
>   create mode 100644 tools/binman/README
>   create mode 120000 tools/binman/binman
>   create mode 100755 tools/binman/binman.py
>   create mode 100644 tools/binman/cmdline.py
>   create mode 100644 tools/binman/control.py
>   create mode 100644 tools/binman/etype/entry.py
>   create mode 100644 tools/binman/image.py

Sounds great. I try to find time to try it, thanks!

Reviewed-by: Heiko Schocher<hs at denx.de>

just some nitpick...

> diff --git a/tools/binman/README b/tools/binman/README
> new file mode 100644
> index 0000000..c73fb3c
> --- /dev/null
> +++ b/tools/binman/README
> @@ -0,0 +1,491 @@
[...]
> +To do
> +-----
> +
> +Some ideas:
> +- Fill out the device tree to include the final position and size of each
> +  entry (since the input file may not always specify these)
> +- Use of-platdata to make the information available to code that is unable
> +  to use device tree (such as a very small SPL image)
> +- Write an image map to a text file
> +- Allow easy building of images by specifying just the board name
> +- Produce a full Python binding for libfdt (for upstream)
> +- Add an option to decode an image into the constituent binaries
> +- Suppoort hierarchical images (packing of binaries into another binary

typing error: Suppoort -> Support

> +  which is then placed in the image)
> +- Support building an image for a board (-b) more completely, with a
> +  configurable build directory
> +- Consider making binman work with buildman, although if it is used in the
> +  Makefile, this will be automatic
> +- Implement align-end
> +
> +--
> +Simon Glass <sjg at chromium.org>
> +7/7/2016

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany