[U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries

Tom Rini trini at konsulko.com
Thu Jul 28 05:28:45 CEST 2016


On Wed, Jul 27, 2016 at 08:33:05PM -0600, Simon Glass wrote:

> The current code for setting up the toolchain config always writes the new
> paths to an item called 'toolchain'. This means that it will overwrite any
> existing toolchain item with the same name. In practice, this means that:
> 
>    buildman --fetch-arch all
> 
> will fetch all toolchains, but only the path of the final one will be added
> to the config. This normally works out OK, since most toolchains are the
> same version (e.g. gcc 4.9) and will be found on the same path. But it is
> not correct and toolchains for archs which don't use the same version will
> not function as expected.
> 
> Adjust the code to use a complete glob of the toolchain path.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160727/8060fab9/attachment-0001.sig>


More information about the U-Boot mailing list