[U-Boot] [PATCH 2/3] mx6cuboxi: Replace is_mx6q() for macro

Stefano Babic sbabic at denx.de
Thu Jul 28 12:39:14 CEST 2016


On 22/07/2016 14:11, Breno Lima wrote:
> It's not necessary to implement the is_mx6q function, there is a macro in
> sys_proto.h already implemented.
> 
> Signed-off-by: Breno Lima <breno.lima at nxp.com>
> ---
>  board/solidrun/mx6cuboxi/mx6cuboxi.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index bcc9729..cafa348 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -367,14 +367,6 @@ int checkboard(void)
>  	return 0;
>  }
>  
> -static bool is_mx6q(void)
> -{
> -	if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
> -		return true;
> -	else
> -		return false;
> -}
> -
>  int board_late_init(void)
>  {
>  #ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
> @@ -383,7 +375,7 @@ int board_late_init(void)
>  	else
>  		setenv("board_name", "CUBOXI");
>  
> -	if (is_mx6q())
> +	if (is_mx6dq())
>  		setenv("board_rev", "MX6Q");
>  	else
>  		setenv("board_rev", "MX6DL");
> @@ -615,7 +607,7 @@ static void spl_dram_init(int width)
>  		.ddr_type = DDR_TYPE_DDR3,
>  	};
>  
> -	if (is_cpu_type(MXC_CPU_MX6D) || is_cpu_type(MXC_CPU_MX6Q))
> +	if (is_mx6dq())
>  		mx6dq_dram_iocfg(width, &mx6q_ddr_ioregs, &mx6q_grp_ioregs);
>  	else
>  		mx6sdl_dram_iocfg(width, &mx6dl_ddr_ioregs, &mx6sdl_grp_ioregs);
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list