[U-Boot] [PATCH v2] treewide: move CONFIG_PHYS_64BIT to Kconfig

B, Ravi ravibabu at ti.com
Thu Jul 28 13:24:12 CEST 2016


Masahiro-san

>>>#if !defined(CONFIG_PPC_P5020) && !defined(CONFIG_PPC_P5040)  #error Must call Cyrus CONFIG with a specific CPU enabled.
>>>#endif
>>>diff --git a/include/configs/dra7xx_evm.h 
>>>b/include/configs/dra7xx_evm.h index 0d51aeb..a11b692 100644
>>>--- a/include/configs/dra7xx_evm.h
>>>+++ b/include/configs/dra7xx_evm.h
>>>@@ -20,7 +20,6 @@
>>> #endif
 
>>>#define CONFIG_VERY_BIG_RAM
>>>-#define CONFIG_PHYS_64BIT

>>Applied this patch on mainline branch, I see warning.  It seems like CONFIG_PHYS_64BIT is not taking effect, the sizeof phys_addr_t is 4 bytes instead of 8 byte.

>Due to removal of CONFIG_PHYS_64BIT in dra7xx_evm.h, phys_addr_t set to 4, and due to SDRAM init would have failed and u-boot prompt did not appear.

>I have defined CONFIG_PHYS_64BIT in dra7xx_evm.h, I did not see any warning and I could see u-boot prompt, worked fine.

>>>board/ti/dra7xx/evm.c: In function 'dram_init_banksize':
>>>board/ti/dra7xx/evm.c:408:30: warning: large integer implicitly 
>>>truncated to unsigned type [-Woverflow]
>>>  gd->bd->bi_dram[1].start = 0x200000000;
                              ^
>>>board/ti/dra7xx/evm.c: In function 'dram_init_banksize':
>>>board/ti/dra7xx/evm.c:408:30: warning: large integer implicitly 
>>>truncated to unsigned type [-Woverflow]
>>> gd->bd->bi_dram[1].start = 0x200000000;
                              ^
Below change fixes the issue.

--------------------------------------------------------------------------
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 870e0fd..2ea1624 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -4,6 +4,10 @@ menu "ARM architecture"
 config SYS_ARCH
        default "arm"
 
+config PHYS_64BIT
+       bool
+       default n
+
 config ARM64
        bool
        select PHYS_64BIT
-----------------------------------------------------------------------------

After applying your patch, the sizeof(phys_addr_t) was always set to 4 bytes.
But expected  sizeof of phys_addr_t supposed to be 8 bytes.
The CONFIG_PHYS_64BIT never gets defined in .config. 

With above patch issue got fixed, please review this change.

Regards
Ravi


More information about the U-Boot mailing list