[U-Boot] [PATCH v2] arm: imx: Add support for Advantech DMS-BA16 board

[Stefano Babic]

Hi Akshay,


On 28/07/2016 12:12, Stefano Babic wrote:
> Hi Akshay,
> 
> this looks good to me. I apply it, and I let you think about an upgrade
> to SPL for this board.
> 

The patch breaks most of i.MX6 boards because it redefines IMX_CONFIG.
In fact:

>>  source "board/ge/bx50v3/Kconfig"
>> +source "board/advantech/dms-ba16/Kconfig"
>>  source "board/aristainetos/Kconfig"
>>  source "board/bachmann/ot1200/Kconfig"
>>  source "board/barco/platinum/Kconfig"
>> diff --git a/board/advantech/dms-ba16/Kconfig b/board/advantech/dms-ba16/Kconfig
>> new file mode 100644
>> index 0000000..cc5b4e3
>> --- /dev/null
>> +++ b/board/advantech/dms-ba16/Kconfig
>> @@ -0,0 +1,27 @@
>> +choice
>> +	prompt "DDR Size"
>> +	default SYS_DDR_2G
>> +
>> +config SYS_DDR_1G
>> +	bool "1GiB"
>> +
>> +config SYS_DDR_2G
>> +	bool "2GiB"
>> +
>> +endchoice
>> +
>> +config IMX_CONFIG
>> +	default "board/advantech/dms-ba16/dms-ba16_2g.cfg" if SYS_DDR_2G
>> +	default "board/advantech/dms-ba16/dms-ba16_1g.cfg" if SYS_DDR_1G
>> +

IMX_CONFIG is already set in arch/arm/imx-common/Kconfig.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================