[U-Boot] [PATCH 3/4] sun8i: On H3 Use word 1 instead of word 3 from the SID

[Hans de Goede]

Hi,

On 27-07-16 21:14, Siarhei Siamashka wrote:
> Hello Hans,

<Snip>

I just realized I forgot to reply to this bit:

> Also changing the MAC address generation algorithm is an invasive
> change, which is affecting the end users.

Agreed, which is why I'm only changing it for the H3 and why I'm
changing it now before ethernet support hits the mainline kernel.

Unfortunately if you look at:

http://linux-sunxi.org/SID_Register_Guide#Currently_known_SID.27s

You will see there are many H3 samples where sid[3] only differs
a single bit with the sid[3] from other boards, and bytes 1-2 of
sid[3] are always 0, so it really is a poor candidate.

 > So IMHO it's best to have
> it implemented properly right from the start, rather than evolving
> via a trial and error method.

Agreed, as I said in my previous mail on this I will go with your
suggestion to hash (well simply ex-or actuallu) 3 of the 4 sid words
and use that for the unique part of the mac / serial.

Thanks for your input on this!

Regards,

Hans