[U-Boot] [PATCH 0/2] Fix gpt write regression

Michael Trimarchi michael at amarulasolutions.com
Fri Jul 29 22:39:46 CEST 2016


Hi Julian

On Wed, Jul 27, 2016 at 3:17 PM, Julian Scheel <julian at jusst.de> wrote:
> Hi,
>
> As pointed out in emails on the threads
> [U-Boot] [RFC PATCH] cmd: gpt: add - partition size parsing
> [U-Boot] [PATCH] cmd: gpt: fix the wrong size parse for the last partition
>

Sounds good. I have fried this weeks already two boards working on
some driver. I will get some test and feedback
tomorow

> it makes no sense to replicate the available size computation from part_efi.c
> into gpt.c. Furthermore the replication was incorrect and caused a regression,
> so that gpt write with a autosized partition did actually fail.
>
> Seeing that Michaels RFC patch was actually made up because gpt verify, which
> compares written gpt table to the table environment variable, failed when
> using size=- for the last partition I added patch 2 of this series. This
> simply disables the size check on verification, if the gpt table in environment
> does not specify a size for a partition. A verification of the computed size
> is not benefitial at all.

Ok, so gpt table is written with the correct value. Yes the overall
idea was to write exact size
on gpt table.  Sorry for the regression

Michael

>
> Regards,
> Julian
>
> Julian Scheel (2):
>   Revert "cmd: gpt: add - partition size parsing"
>   disk: part_efi: Omit size on verify for partitions without size
>
>  cmd/gpt.c       | 13 ++-----------
>  disk/part_efi.c |  3 ++-
>  2 files changed, 4 insertions(+), 12 deletions(-)
>
> --
> 2.9.0
>



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |


More information about the U-Boot mailing list