[U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

Andrew Shadura andrew.shadura at collabora.co.uk
Tue Jun 7 10:27:00 CEST 2016


On 31/05/16 17:55, Andrew Shadura wrote:
> On 31/05/16 17:35, Stefano Babic wrote:
>> > But this generates a warning:
>> > 
>> > w+board/ge/bx50v3/bx50v3.c:324:12: warning: 'detect_baseboard' defined
>> > but not used [-Wunused-function]
>> > 
>> > Why do you export it if you do not need it ? It is used only in the hdmi
>> > detection, that means just if IPU is set.
> Strange, it wouldn't compile here unless I did this. Apparently it *was*
> used from somewhere else, but maybe it's no longer. Let me double check.

It seems it was a mistake and this patch may indeed not be needed.

Stefano, are there any comments on other patches?

-- 
Cheers,
  Andrew

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160607/649f6cfd/attachment.sig>


More information about the U-Boot mailing list