[U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

Stefano Babic sbabic at denx.de
Tue Jun 7 10:57:46 CEST 2016


On 07/06/2016 10:27, Andrew Shadura wrote:
> On 31/05/16 17:55, Andrew Shadura wrote:
>> On 31/05/16 17:35, Stefano Babic wrote:
>>>> But this generates a warning:
>>>>
>>>> w+board/ge/bx50v3/bx50v3.c:324:12: warning: 'detect_baseboard' defined
>>>> but not used [-Wunused-function]
>>>>
>>>> Why do you export it if you do not need it ? It is used only in the hdmi
>>>> detection, that means just if IPU is set.
>> Strange, it wouldn't compile here unless I did this. Apparently it *was*
>> used from somewhere else, but maybe it's no longer. Let me double check.
> 
> It seems it was a mistake and this patch may indeed not be needed.
> 
> Stefano, are there any comments on other patches?
> 

Other patches are fine. Then we agree to apply patches 2-8, and I drop 1/8.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list