[U-Boot] [PATCH 7/8] x86: Probe pinctrl driver in cpu_init_r()

Bin Meng bmeng.cn at gmail.com
Sun Jun 12 06:24:17 CEST 2016


On Sat, Jun 11, 2016 at 2:33 AM, George McCollister
<george.mccollister at gmail.com> wrote:
> On Wed, Jun 8, 2016 at 7:07 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> At present pinctrl driver gets probed in ich6_gpio driver's probe
>> routine, which has two issues:
>>
>>  - Pin's PADs only gets configured when GPIO driver is probed, which
>>    is not done by default. This leaves the board in a partially
>>    functional state as we must initialize PADs correctly to get
>>    perepherals fully working.
>>  - The probe routine of pinctrl driver is called multiple times, as
>>    normally there are multiple GPIO controllers. It should really
>>    be called just once.
>>
>> Move the call to syscon_get_by_driver_data() from ich6_gpio driver
>> to cpu_init_r().
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> Reviewed-by: George McCollister <george.mccollister at gmail.com>
> Tested-by: George McCollister <george.mccollister at gmail.com>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list