[U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata

[Alexander Graf]

> Am 02.03.2016 um 12:29 schrieb Adam Ford <aford173 at gmail.com>:
> 
>> On Tue, Mar 1, 2016 at 6:01 PM, Alexander Graf <agraf at suse.de> wrote:
>> 
>> 
>>> On 02.03.16 00:23, Adam Ford wrote:
>>> A few boards still use ns16550_platdata structures, but assume the structure
>>> is going to be in a specific order. By explicitly naming each entry,
>>> this should also help 'future-proof' in the event the structure changes.
>>> 
>>> Tested on the Logic PD Torpedo + Wireless.
>>> 
>>> I only changed a handful of devices that used the same syntax as the Logic
>>> board.  Appologies if I missed one or stepped on toes.  Thanks to Derald Woods
>>> and Alexander Graf.
>>> 
>>> Signed-off-by: Adam Ford <aford173 at gmail.com>
>>> 
>>> V4: Fix subject heading
>>> 
>>> V3: Remove  reg_offset out in all the structs. It was reverted out, and and if
>>> it did exist, it would get initialized to 0 by default.
>>> 
>>> V2: I hastily copy-pasted the boards without looking at the UART number.
>>> This addresses 3 boards that use UART3 and not UART1.
>>> ---
>>> board/isee/igep00x0/igep00x0.c      | 6 +++---
>>> board/logicpd/omap3som/omap3logic.c | 6 +++---
>>> board/logicpd/zoom1/zoom1.c         | 6 +++---
>>> board/overo/overo.c                 | 6 +++---
>>> board/quipos/cairo/cairo.c          | 6 +++---
>>> board/ti/beagle/beagle.c            | 6 +++---
>>> board/timll/devkit8000/devkit8000.c | 6 +++---
>> 
>> Looks to me like you didn't catch all boards out there. I don't think it
>> makes sense to limit yourself to OMAP3, otherwise different boards (that
>> people may not realize are broken that fast) break next time...
>> 
>> arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> I will fix and  CC its maintainer.
> 
>> arch/arm/cpu/armv7/am33xx/board.c
> These boards already have a pending patch from TI.
> 
>> arch/arm/mach-tegra/board.c
> Already in git master.
> 
>> board/isee/igep00x0/igep00x0.c
> I my patch
> 
>> board/lge/sniper/sniper.c
> Already in git master
> 
>> board/logicpd/omap3som/omap3logic.c
>> board/logicpd/zoom1/zoom1.c
>> board/overo/overo.c
>> board/quipos/cairo/cairo.c
>> board/ti/beagle/beagle.c
>> board/timll/devkit8000/devkit8000.c
> 
> The rest should have all been included in my original patch, so I
> think they are addressed.  Does that address your concern?  If so,
> I'll push another revision that adds
> arch/arm/cpu/arm926ejs/lpc32xx/devices.c.

Yes, thanks a lot!

Alex