[U-Boot] [PATCH v3 1/3] board:freescale:common: Move device-tree fixup framework to common file

[Sriram Dash]

>-----Original Message-----
>From: Marek Vasut [mailto:marex at denx.de]
>Sent: Thursday, March 03, 2016 3:26 PM
>To: Sriram Dash <sriram.dash at nxp.com>; u-boot at lists.denx.de
>Cc: york sun <york.sun at nxp.com>; Ramneek Mehresh
><ramneek.mehresh at nxp.com>; Rajesh Bhagat <rajesh.bhagat at nxp.com>; Tom
>Rini <trini at konsulko.com>
>Subject: Re: [PATCH v3 1/3] board:freescale:common: Move device-tree fixup
>framework to common file
>
>On 03/03/2016 09:29 AM, Sriram Dash wrote:
>>
>>
>>> -----Original Message-----
>>> From: Marek Vasut [mailto:marex at denx.de]
>>> Sent: Wednesday, March 02, 2016 3:43 AM
>>> To: Sriram Dash <sriram.dash at nxp.com>; u-boot at lists.denx.de
>>> Cc: york sun <york.sun at nxp.com>; Ramneek Mehresh
>>> <ramneek.mehresh at nxp.com>; Rajesh Bhagat <rajesh.bhagat at nxp.com>; Tom
>>> Rini <trini at konsulko.com>
>>> Subject: Re: [PATCH v3 1/3] board:freescale:common: Move device-tree
>>> fixup framework to common file
>>>
>>> On 03/01/2016 08:03 AM, Sriram Dash wrote:
>>>> Move usb device-tree fixup framework from ehci-fsl.c to common place
>>>> so that it can be used by other drivers as well (xhci-fsl.c).
>>>>
>>>> Signed-off-by: Ramneek Mehresh <ramneek.mehresh at nxp.com>
>>>> Signed-off-by: Sriram Dash <sriram.dash at nxp.com>
>>>> ---
>>>>  board/freescale/common/Makefile                    |   2 +
>>>>  .../ehci-fsl.c => board/freescale/common/usb.c     | 160 +----------------
>>>>  drivers/usb/host/ehci-fsl.c                        | 195 ---------------------
>>>>  3 files changed, 3 insertions(+), 354 deletions(-)  copy
>>>> drivers/usb/host/ehci-fsl.c => board/freescale/common/usb.c (53%)
>>>
>>> Where is the changelog ?
>>
>> Will include changelog for v2 and v3 in v4.
>>
>>>
>>>> diff --git a/board/freescale/common/Makefile
>>>> b/board/freescale/common/Makefile index be114ce..62de45c 100644
>>>> --- a/board/freescale/common/Makefile
>>>> +++ b/board/freescale/common/Makefile
>>>> @@ -13,6 +13,8 @@ MINIMAL=y
>>>>  endif
>>>>  endif
>>>>
>>>> +obj-$(CONFIG_USB_EHCI_FSL) += usb.o
>>>> +
>>>>  ifdef MINIMAL
>>>>  # necessary to create built-in.o
>>>>  obj- := __dummy__.o
>>>> diff --git a/drivers/usb/host/ehci-fsl.c
>>>> b/board/freescale/common/usb.c similarity index 53% copy from
>>>> drivers/usb/host/ehci-fsl.c copy to board/freescale/common/usb.c
>>>> index 97b7f14..85cb1bf 100644
>>>> --- a/drivers/usb/host/ehci-fsl.c
>>>> +++ b/board/freescale/common/usb.c
>>>> @@ -1,9 +1,5 @@
>>>>  /*
>>>> - * (C) Copyright 2009, 2011 Freescale Semiconductor, Inc.
>>>> - *
>>>> - * (C) Copyright 2008, Excito Elektronik i Sk=E5ne AB
>>>> - *
>>>> - * Author: Tor Krill tor at excito.com
>>>> + * (C) Copyright 2016 Freescale Semiconductor, Inc.
>>>
>>> What's with this copyright change here ?
>>
>> It is a new file named common/usb.c. Shall I include the complete ehci-fsl.c
>copyright information in the new file?
>
>There is already a file named common/usb.c , you surely mean
>board/freescale/common/usb.c , yes ?
>

Yes

>According to git, it's not a new file:
>
>b/board/freescale/common/usb.c similarity index 53% copy from
>drivers/usb/host/ehci-fsl.c copy to board/freescale/common/usb.c
>
>so yes, it should retain all copyright info.
>

Ok, We will retain copyright info in v4.

>And now that I am looking at it, I would much rather see the fixup bits in
>drivers/usb/host/ than some board-specific file. You can very well put those into
>fsl-dt-fixup.c or whatever there.
>

drivers/usb/host/ was a good option, but we want to make it independent of 
host and gadget. So, whenever there is a specific requirement for freescale boards,
it will use the same from board: freescale: common: usb

Else, another option is to have drivers/usb/common/fsl-dt-fixup.c.
What do you say?

>>>
>>>>   * SPDX-License-Identifier:	GPL-2.0+
>>>>   */
>>>> @@ -17,164 +13,11 @@
>>>>  #include <fsl_usb.h>
>>>>  #include <fdt_support.h>
>>>>
>>>> -#include "ehci.h"
>>> [...]
>>>
>>> --
>>> Best regards,
>>> Marek Vasut
>>
>> Best Regards,
>> Sriram
>>
>
>
>--
>Best regards,
>Marek Vasut