[U-Boot] [U-BOOT.V2] usb: xhci: Fix vendor command error if the request

[Anand Moon]

Hi Marek,

On 5 March 2016 at 18:00, Marek Vasut <marex at denx.de> wrote:
> On 03/05/2016 09:43 AM, Anand Moon wrote:
>> From: Ted Chen <tedchen at realtek.com>
>>
>> From: Ted Chen <tedchen at realtek.com>
>>
>> type is USB_REQ_SET_ADDRESS or USB_REQ_SET_CONFIGURATION.
>> To: marex at denx.de, swarren at nvidia.com, u-boot at lists.denx.de
>> Cc: linux.amoon at gmail.com, Ted Chen <tedchen at realtek.com>
>>
>> Add a condition of set_address and set_configuration to check
>> if the request is standardized.
>
> Can you please rephrase the commit message ? It's really hard to
> understand. I believe such a patch will be needed for ehci as well,
> can you prepare one ?

I could not find any need for such check in ehci-hcd driver.

Sorry for this mess in commit message, I completely missed formatting
the statement
because of it got warped up in the message
Will send this message again with proper commit message.

>
>> Signed-off-by: Ted Chen <tedchen at realtek.com>
>> ---
>> Resend this patch it some how got missed
>> Changes since v1: None.
>>
>> Tested on Odroid XU4: with Ethernet USB3.0 RT8153-VB
>> ---
>>  drivers/usb/host/xhci.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> index ca598aa..cb8a04b 100644
>> --- a/drivers/usb/host/xhci.c
>> +++ b/drivers/usb/host/xhci.c
>> @@ -941,10 +941,12 @@ static int _xhci_submit_control_msg(struct usb_device *udev, unsigned long pipe,
>>       if (usb_pipedevice(pipe) == ctrl->rootdev)
>>               return xhci_submit_root(udev, pipe, buffer, setup);
>>
>> -     if (setup->request == USB_REQ_SET_ADDRESS)
>> +     if (setup->request == USB_REQ_SET_ADDRESS &&
>> +        (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD)
>>               return xhci_address_device(udev, root_portnr);
>>
>> -     if (setup->request == USB_REQ_SET_CONFIGURATION) {
>> +     if (setup->request == USB_REQ_SET_CONFIGURATION &&
>> +        (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD) {
>>               ret = xhci_set_configuration(udev);
>>               if (ret) {
>>                       puts("Failed to configure xHCI endpoint\n");
>>
>
> What happens to the non-standard requests ?
>
Device will not able to detect leaving message
"scanning usb for ethernet devices... Non standard request in USB
vendor command"
> --
> Best regards,
> Marek Vasut

Here is the modified commit message

"Add a condition of set_address and set_configuration to check
if the requesttype is of standardized in the USB vendor request
so that usb device is detected"

Do you agree with this modified commit statement.

Best regards,
-Anand Moon