[U-Boot] [PATCH 42/69] x86: Add comments to the SIPI vector

Simon Glass sjg at chromium.org
Mon Mar 7 03:28:25 CET 2016


The Intel SIPI (start-up inter-processor interrupt) vector is the entry
point for each secondary CPU (also called an AP - applications processor).
The assembler and C code are linked, so add comments to indicate this.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 arch/x86/cpu/sipi_vector.S  | 1 +
 arch/x86/include/asm/sipi.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/x86/cpu/sipi_vector.S b/arch/x86/cpu/sipi_vector.S
index 0c4a157..94c0f5a 100644
--- a/arch/x86/cpu/sipi_vector.S
+++ b/arch/x86/cpu/sipi_vector.S
@@ -193,6 +193,7 @@ load_msr:
 	mov	c_handler, %esi
 	call	*%esi
 
+	/* This matches struct sipi_param */
 	.align	4
 .globl	sipi_params
 sipi_params:
diff --git a/arch/x86/include/asm/sipi.h b/arch/x86/include/asm/sipi.h
index 25d7d31..da91a48 100644
--- a/arch/x86/include/asm/sipi.h
+++ b/arch/x86/include/asm/sipi.h
@@ -42,6 +42,7 @@ struct __packed sipi_params_16bit {
  * struct sipi_params - 32-bit SIP entry-point parameters
  *
  * These are used by the AP init code and must be set up before the APs start.
+ * The members must match with the sipi_params layout in sipi_vector.S.
  *
  * The stack area extends down from @stack_top, with @stack_size allocated
  * for each AP.
-- 
2.7.0.rc3.207.g0ac5344



More information about the U-Boot mailing list