[U-Boot] [PATCH] usb: Add new command to regress USB devices

[Simon Glass]

Hi,

On 9 March 2016 at 05:55, Marek Vasut <marex at denx.de> wrote:
>
> On 03/09/2016 01:21 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 09-03-16 12:28, Marek Vasut wrote:
> >> On 03/09/2016 12:22 PM, Rajat Srivastava wrote:
> >>> This patch adds a new 'usb regress' command, that can be used to
> >>> regress test a USB device. It performs the following operations:
> >>>
> >>> 1. starts the USB device
> >>> 2. performs read/write operations
> >>> 3. stops the USB device
> >>> 4. verifies the contents of read/write operations
> >>>
> >>> Sample Output:
> >>> => usb regress 81000000 82000000 32m
> >>> regressing USB..
> >>> starting USB...
> >>> USB0:   Register 200017f NbrPorts 2
> >>> Starting the controller
> >>> USB XHCI 1.00
> >>> scanning bus 0 for devices... 2 USB Device(s) found
> >>>         scanning usb for storage devices... 1 Storage Device(s) found
> >>> USB write: device 0 block # 0, count 65536 ... 65536 blocks write: OK
> >>> USB read: device 0 block # 0, count 65536 ... 65536 blocks read: OK
> >>> stopping USB..
> >>> verifying data on addresses 0x81000000 and 0x82000000
> >>> Total of 65536 word(s) were the same
> >>>
> >>> Signed-off-by: Rajat Srivastava <rajat.srivastava at nxp.com>
> >>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>
> >>
> >>
> >> Does it do anything which cannot be achieved on the command line itself
> >> using "usb reset" "usb write" "usb read" "cmp" commands ?
> >
> > This seems to be about a reading / writing a usb-disk / usb-storage device.
>
> That's what usb read / usb write commands are for, reading raw data from
> USB disk :-)
>
> > I believe this can certainly be achieved with the existing disk io
> > commands,
> > and moreover this seems quite dangerous (overwriting the partition table on
> > the device), so I think requiring the user to do this explicitly indeed
> > seems better.
>
> Yeah
>
> > Regards,
> >
> > Hans

We do have an 'sf test' command. I think it is useful, particularly if
it measures speed as well.

Regards,
Simon