[U-Boot] [PATCH 53/69] x86: broadwell: Add a pinctrl driver

Bin Meng bmeng.cn at gmail.com
Fri Mar 11 09:19:55 CET 2016


On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass <sjg at chromium.org> wrote:
> GPIO pins need to be set up on start-up. Add a driver to provide this,
> configured from the device tree.
>
> The binding is slightly different from the existing ICH6 binding, since that
> is quite verbose. The new binding should be just as extensible.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/cpu/broadwell/Makefile                    |   1 +
>  arch/x86/cpu/broadwell/pinctrl_broadwell.c         | 278 +++++++++++++++++++++
>  arch/x86/include/asm/arch-broadwell/gpio.h         |  91 +++++++
>  .../gpio/intel,x86-broadwell-pinctrl.txt           | 208 +++++++++++++++
>  include/dt-bindings/gpio/x86-gpio.h                |  12 +
>  5 files changed, 590 insertions(+)
>  create mode 100644 arch/x86/cpu/broadwell/pinctrl_broadwell.c
>  create mode 100644 arch/x86/include/asm/arch-broadwell/gpio.h
>  create mode 100644 doc/device-tree-bindings/gpio/intel,x86-broadwell-pinctrl.txt
>

Except several nits about "GPL-2.0+" and capital letters for the
__asm_arch_gpio, generally it looks good, so
Acked-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list