[U-Boot] [PATCH 1/4] arm: iproc: add NAND driver

Steve Rae steve.rae at broadcom.com
Fri Mar 11 19:07:46 CET 2016


Is it expected the _every_ CONFIG_* and CONFIG_SYS_* will be moved to Kconfig?
What about #defines that will absolutely never used by anyone else?
for example, I (may) have a code fragment that distinguishes between
"CONFIG_CYGNUS" and "CONFIG_NSPLUS"...
Would these need to be Kconfig? or would that just clutter Kconfig
with useless entries?
Thanks for clarifying!


On Fri, Mar 11, 2016 at 10:02 AM, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Mar 10, 2016 at 02:26:27PM -0800, Steve Rae wrote:
>
>> From: Jiandong Zheng <jdzheng at broadcom.com>
>>
>> Add support for the iproc NAND, and enable on Cygnus and NSP boards.
>>
>> Signed-off-by: Jiandong Zheng <jdzheng at broadcom.com>
>> Signed-off-by: Steve Rae <srae at broadcom.com>
>> ---
>> There was a previous attempt to implement this "iproc NAND"
>> (see: http://patchwork.ozlabs.org/patch/505399), however, due to the
>> amount of changes required, it seemed better to implement the code
>> in a series of steps. This is the first step, where the "iproc_nand.c"
>> is essentially an empty file (with one function required to allow this
>> commit to build successfully).
>>
>>  arch/arm/include/asm/arch-bcmcygnus/configs.h |  11 +++
>>  arch/arm/include/asm/arch-bcmnsp/configs.h    |  11 +++
>>  drivers/mtd/nand/Makefile                     |   1 +
>>  drivers/mtd/nand/iproc_nand.c                 |  11 +++
>>  drivers/mtd/nand/iproc_nand_cygnus.h          | 111 +++++++++++++++++++++++++
>>  drivers/mtd/nand/iproc_nand_ns_plus.h         | 113 ++++++++++++++++++++++++++
>>  6 files changed, 258 insertions(+)
>
> We need to be adding Kconfig entries here at a minimum.
>
> --
> Tom


More information about the U-Boot mailing list