[U-Boot] [PATCH v2 0/3] Add LVDS support for rk3288

Simon Glass sjg at chromium.org
Sun Mar 13 20:03:07 CET 2016


Hi Jacob,

On 13 March 2016 at 11:45, Jacob Chen <jacob-chen at iotwrt.com> wrote:
> This series patches add LVDS support for rk3288.
>
>
> Jacob Chen (3):
>   Add a bingding file for rockchip video
>   rockchip: video: Add a display driver for rockchip LVDS
>   doc: dt-bindings: Describe rockchip LVDS interface
>
>  arch/arm/dts/rk3288.dtsi                         |   1 +
>  arch/arm/include/asm/arch-rockchip/lvds_rk3288.h |  97 +++++++++
>  doc/device-tree-bindings/video/rockchip-lvds.txt |  77 +++++++
>  drivers/video/rockchip/Makefile                  |   2 +-
>  drivers/video/rockchip/rk_lvds.c                 | 254 +++++++++++++++++++++++
>  include/dt-bindings/video/rk3288.h               |  11 +
>  6 files changed, 441 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/include/asm/arch-rockchip/lvds_rk3288.h
>  create mode 100644 doc/device-tree-bindings/video/rockchip-lvds.txt
>  create mode 100644 drivers/video/rockchip/rk_lvds.c
>  create mode 100644 include/dt-bindings/video/rk3288.h

This looks OK, but please can you send v3 with:

- A change log for v2 in each patch that you changed
- Include all the patches again (add my Acked-by in the ones that I acked)

The reason for the last one is that that otherwise the patches get
renumbered. It is something useful to send only changed patches, but
normally only when you are changing a few patches of a large series.
For a series with 5 patches you may as well just send the whole thing
again.

Regards,
Simon


More information about the U-Boot mailing list