[U-Boot] [PATCH v2 17/51] x86: Move common PCH code into a common place

Bin Meng bmeng.cn at gmail.com
Mon Mar 14 06:02:16 CET 2016


Hi Simon,

On Sat, Mar 12, 2016 at 1:07 PM, Simon Glass <sjg at chromium.org> wrote:
> The SATA indexed register write functions are common to several Intel PCHs.
> Move this into a common location.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2: None
>
>  arch/x86/cpu/intel_common/Makefile        |  1 +
>  arch/x86/cpu/intel_common/pch_common.c    | 25 ++++++++++++++

Can you rename this to pch.c, to keep consistency with other files in
the same directory?

>  arch/x86/cpu/ivybridge/cpu.c              |  1 +
>  arch/x86/cpu/ivybridge/sata.c             | 47 +++++++++-----------------
>  arch/x86/include/asm/arch-ivybridge/pch.h | 53 -----------------------------
>  arch/x86/include/asm/pch_common.h         | 56 +++++++++++++++++++++++++++++++
>  6 files changed, 99 insertions(+), 84 deletions(-)
>  create mode 100644 arch/x86/cpu/intel_common/pch_common.c
>  create mode 100644 arch/x86/include/asm/pch_common.h
>

Regards,
Bin


More information about the U-Boot mailing list