[U-Boot] [PATCH v2 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled

Tom Rini trini at konsulko.com
Mon Mar 14 16:25:16 CET 2016


On Sun, Mar 13, 2016 at 07:07:31PM -0600, Simon Glass wrote:

> Command parsing and processing code is not needed when the command line is
> disabled. Remove this code in that case.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
[snip]
> @@ -102,7 +104,11 @@ int run_command_list(const char *cmd, int len, int flag)
>  	 * doing a malloc() which is actually required only in a case that
>  	 * is pretty rare.
>  	 */
> +# ifdef CONFIG_CMDLINE
>  	rcode = cli_simple_run_command_list(buff, flag);
> +# else
> +	rcode = board_run_command(buff);
> +# endif
>  #endif

nit: We don't usually space-indent preprocessor tests and don't anywhere
else in this file either.

Otherwise:

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160314/2b0c98b5/attachment.sig>


More information about the U-Boot mailing list