[U-Boot] [PATCH v5 2/4] usb: Remove 200 ms delay in usb_hub_port_connect_change()

Bin Meng bmeng.cn at gmail.com
Wed Mar 16 03:29:50 CET 2016


On Tue, Mar 15, 2016 at 8:59 PM, Stefan Roese <sr at denx.de> wrote:
> This patch removes 2 mdelay(200) calls from usb_hub_port_connect_change().
> These delays don't seem to be necessary. At least not in my tests. Here
> the number for a custom x86 Bay Trail board (not in mainline yet) with
> a quite large and complex USB hub infrastructure.
>
> Without this patch:
> starting USB...
> USB0:   USB EHCI 1.00
> scanning bus 0 for devices... 9 USB Device(s) found
>
> time: 28.415 seconds
>
> With this patch:
> starting USB...
> USB0:   USB EHCI 1.00
> scanning bus 0 for devices... 9 USB Device(s) found
>
> time: 24.003 seconds
>
> So ~4.5 seconds of USB scanning time reduction.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> Acked-by: Hans de Goede <hdegoede at redhat.com>
> Tested-by: Stephen Warren <swarren at nvidia.com>
> Cc: Marek Vasut <marex at denx.de>
>
> ---
>
> Changes in v5: None
> Changes in v4:
> - Add Acked-by / Tested-by from Hans and Stephen
>
> Changes in v3: None
> Changes in v2:
> - Make this change unconditional
> - Add Acked-by / Tested-by from Hans and Stephen
>
>  common/usb_hub.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Tested-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list