[U-Boot] [PATCH] x86: Add congatec conga-QA3/E3845-4G (Bail Trail) support

[Bin Meng]

Hi Stefan,

On Wed, Mar 16, 2016 at 3:31 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Stefan,
>
> On Wed, Mar 16, 2016 at 2:32 PM, Stefan Roese <sr at denx.de> wrote:
>> Hi Bin,
>>
>> On 16.03.2016 03:18, Bin Meng wrote:
>>>
>>> On Wed, Mar 16, 2016 at 12:14 AM, Stefan Roese <sr at denx.de> wrote:
>>>>
>>>> This patch adds support for the congatec conga-QA3/E3845-4G eMMC8 SoM,
>>>> installed on the congatec Qseven 2.0 evaluation carrier board
>>>> (conga-QEVAL).
>>>>
>>>> Its port is very similar to the MinnowboardMAX port and also uses
>>>> the Intel FSP as described in doc/README.x86.
>>>>
>>>> Currently supported are the following interfaces / devices:
>>>> - UART (via Winbond legacy SuperIO chip on carrier board)
>>>> - Ethernet (PCIe Intel I210 / E1000)
>>>> - SPI including SPI NOR as boot-device
>>>> - USB 2.0
>>>> - SATA via U-Boot SCSI IF
>>>> - eMMC
>>>> - Video (HDMI output @ 800x600)
>>>> - PCIe
>>>>
>>>
>>> Great job to support another x86 target!
>>
>>
>> Thanks. All possible because of your (and Simon's and others) great
>> work you have done on this platform in the last years. :)
>>
>
> [snip]
>
>>>> diff --git a/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
>>>> b/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
>>>> new file mode 100644
>>>> index 0000000..ab6883e
>>>> --- /dev/null
>>>> +++ b/board/congatec/conga-qeval20-qa3-e3845/conga-qeval20-qa3.c
>>>> @@ -0,0 +1,39 @@
>>>> +/*
>>>> + * Copyright (C) 2016 Stefan Roese <sr at denx.de>
>>>> + *
>>>> + * SPDX-License-Identifier:    GPL-2.0+
>>>> + */
>>>> +
>>>> +#include <common.h>
>>>> +#include <winbond_w83627.h>
>>>> +#include <asm/gpio.h>
>>>> +#include <asm/ibmpc.h>
>>>> +#include <asm/pnp_def.h>
>>>> +
>>>> +int board_early_init_f(void)
>>>> +{
>>>> +       /*
>>>> +        * The FSP enables the BayTrail internal legacy UART (again).
>>>> +        * Disable it again, so that the Winbond one can be used.
>>>> +        */
>>>> +       setup_internal_uart(0);
>>>> +
>>>> +       /* Enable the legacy UART in the Winbond W83627 Super IO chip */
>>>> +       winbond_enable_serial(PNP_DEV(WINBOND_IO_PORT, W83627DHG_SP1),
>>>> +                             UART0_BASE, UART0_IRQ);
>>>> +
>>>> +       return 0;
>>>> +}
>>>> +
>>>> +int arch_early_init_r(void)
>>>> +{
>>>> +       /* do the pin-muxing */
>>>> +       gpio_ich6_pinctrl_init();
>>>> +
>>>
>>>
>>> I guess this needs to be rebased on top of u-boot-x86/master.
>>
>>
>> I tried and this is currently problematic since u-boot-x86/master
>> does not include Simon's SPL / FIT patchset yet. And master already
>> does.
>>
>> Could you please rebase u-boot-x86/master on top of current master?
>> This would make it easy for me to generate a v2 of this congatec
>> board support.
>
> I've just rebased u-boot-x86/master. Please have another try.
>
> [snip]
>

BTW: just noticed that the commit title has a typo. It should be "Bay
Trail", not "Bail Trail" :)

Regards,
Bin