[U-Boot] [PATCH 03/14] mkimage: Correct file being closed twice in fit_extract_data()

Simon Glass sjg at chromium.org
Wed Mar 16 14:45:33 CET 2016


The code flows through to the end of the function, so we don't need another
close() before this. Remove it.

Reported-by: Coverity (CID: 138503)

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 tools/fit_image.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/fit_image.c b/tools/fit_image.c
index 31aa43c..8a93ea3 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -446,8 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname)
 		ret = -EIO;
 		goto err;
 	}
-	close(fd);
-
 	ret = 0;
 
 err:
-- 
2.7.0.rc3.207.g0ac5344



More information about the U-Boot mailing list