[U-Boot] [PATCH 14/14] usb: Correct return value in usb_stor_info()

Marek Vasut marex at denx.de
Wed Mar 16 16:50:19 CET 2016


On 03/16/2016 02:45 PM, Simon Glass wrote:
> This should return 0 on success, not 1. Fix it.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

Yikes. Thanks for finding this.

Acked-by: Marek Vasut <marex at denx.de>

> ---
> 
>  common/usb_storage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index 1472824..18fdf73 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -193,7 +193,7 @@ int usb_stor_info(void)
>  		return 1;
>  	}
>  
> -	return 1;
> +	return 0;
>  }
>  
>  static unsigned int usb_get_max_lun(struct us_data *us)
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list