[U-Boot] [PATCH] sunxi: Fix gmac not working due to cpu_eth_init no longer being called

Ian Campbell ijc+uboot at hellion.org.uk
Thu Mar 17 17:27:58 CET 2016


On Thu, 2016-03-17 at 15:38 +0100, Hans de Goede wrote:
> Hi,
> 
> On 17-03-16 14:21, Ian Campbell wrote:
> > 
> > On Thu, 2016-03-17 at 14:02 +0100, Hans de Goede wrote:
> > > 
> > > cpu_eth_init is no longer called for dm enabled eth drivers, this
> > > was causing the sunxi gmac eth controller to no longer work in u-
> > > boot.
> > > 
> > > This commit fixes this by moving the gpio setup to gpio_init()
> > > and by
> > > calling the clock, reset and pinmux setup function from s_init().
> > > 
> > > Note that the mdelay is dropped as the phy gets enabled much
> > > earlier
> > > now, so it is no longer needed.
> > Everything is DM_ETH based now, right? Which is why this final hunk is
> > OK?
> Correct, we only do DM for eth in sunxi now,

Super. Acked-by: Ian Campbell <ijc at hellion.org.uk>

Ian.


More information about the U-Boot mailing list