[U-Boot] [PATCH v4 3/4] drivers:usb:common:fsl-dt-fixup: Add device-tree fixup support for xhci controller

[Sriram Dash]

>-----Original Message-----
>From: Marek Vasut [mailto:marex at denx.de]
>Sent: Friday, March 11, 2016 10:14 PM
>To: Sriram Dash <sriram.dash at nxp.com>; u-boot at lists.denx.de
>Cc: york sun <york.sun at nxp.com>; Ramneek Mehresh
><ramneek.mehresh at nxp.com>; Rajesh Bhagat <rajesh.bhagat at nxp.com>
>Subject: Re: [PATCH v4 3/4] drivers:usb:common:fsl-dt-fixup: Add device-tree fixup
>support for xhci controller
>
>On 03/11/2016 07:26 AM, Sriram Dash wrote:
>> Enables usb device-tree fixup code to incorporate xhci controller
>>
>> Signed-off-by: Ramneek Mehresh <ramneek.mehresh at nxp.com>
>> Signed-off-by: Sriram Dash <sriram.dash at nxp.com>
>> ---
>> Changes in v4:
>>   - Use a terminating entry in the array for getting node type for
>> controller Changes in v3:
>>   - Modify the Makefile to remove comparison
>>   - Put the supported controllers in array and checking from array
>> Changes in v2:
>>   - Remove the #defines from the patch and adding controller support
>>
>>  drivers/usb/common/Makefile       |  1 +
>>  drivers/usb/common/fsl-dt-fixup.c | 44 +++++++++++++++++++--------------------
>>  include/fdt_support.h             |  4 ++--
>>  3 files changed, 25 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile
>> index a38ee4a..2f3d43d 100644
>> --- a/drivers/usb/common/Makefile
>> +++ b/drivers/usb/common/Makefile
>> @@ -4,3 +4,4 @@
>>  #
>>
>>  obj-$(CONFIG_USB_EHCI_FSL) += fsl-dt-fixup.o
>> +obj-$(CONFIG_USB_XHCI_FSL) += fsl-dt-fixup.o
>> diff --git a/drivers/usb/common/fsl-dt-fixup.c
>> b/drivers/usb/common/fsl-dt-fixup.c
>> index 64e20d8..b574127 100644
>> --- a/drivers/usb/common/fsl-dt-fixup.c
>> +++ b/drivers/usb/common/fsl-dt-fixup.c
>> @@ -19,15 +19,21 @@
>>  #define CONFIG_USB_MAX_CONTROLLER_COUNT 1  #endif
>>
>> -static const char *fdt_usb_get_node_type(void *blob, int
>> start_offset,
>> +static char *fdt_usb_get_node_type(void *blob, int start_offset,
>>  					 int *node_offset);
>>
>> +char compat_usb_fsl[] = {
>
>static const
>

Will take care in v5.

>> +	"fsl-usb2-mph" "\0"
>> +	"fsl-usb2-dr" "\0"
>> +	"snps,dwc3" "\0"
>> +};
>> +
>>  static int fdt_fixup_usb_mode_phy_type(void *blob, const char *mode,
>>  				       const char *phy_type, int start_offset)  {
>>  	const char *prop_mode = "dr_mode";
>>  	const char *prop_type = "phy_type";
>> -	const char *node_type = NULL;
>> +	char *node_type = NULL;
>>  	int node_offset;
>>  	int err;
>>
>> @@ -54,29 +60,23 @@ static int fdt_fixup_usb_mode_phy_type(void *blob,
>const char *mode,
>>  	return node_offset;
>>  }
>[...]
>
>
>--
>Best regards,
>Marek Vasut