[U-Boot] [PATCH v4 00/14] Add Support for Secure Boot on LS208x

[york sun]

On 02/08/2016 09:26 PM, Saksham Jain wrote:
> Secure Boot ESBC has been enabled on FSL LS208x platforms.
> 
> Changes for v2:
> 	- changed function fsl_secboot_validate to return address of image
> 	- corrected Bootscript header for ls1043 and ls1021
> Changes for v3:
> 	- minor changes to remove compilation warnings
> Changes ofr v4:
> 	- removed IE Key extenstion support. Methodology not fixed yet.
> 	- minor changes in commit messages (clean up)
> 
> 
> Saksham Jain (14):
>   armv8: ls2080: Add SFP Configs for LS2080/LS2085
>   armv8: ls2080: Add Secure Boot configs: SEC, Security Monitor, SRK and
>     RCW
>   SECURE BOOT: Add new ESBC header for ls-ch3 Secure Boot
>   SECURE BOOT: Add Secure Boot support on ls2080aqds/rdb
>   armv8: fsl-lsch3: Add bootscript header address for Secure Boot
>   SECURE BOOT: Copy Bootscript and header from NOR to DDR for LS2080/5
>   SECURE BOOT: Change env variable "fdt_high" for LS2080a and LS2085a
>   armv8 : ls2080: Add config for endianess of CCSR GUR
>   armv8: fsl-lsch3: Disable SMMU during Secure Boot
>   crypto/fsl: Correct 64bit Write when MMU disabled
>   crypto/fsl: Make CAAM transactions cacheable
>   SECURE_BOOT: Use default bootargs during Secure Boot
>   SECURE BOOT: Halt execution when secure boot fail after reset request
>   SECURE BOOT: Change fsl_secboot_validate function to output image addr
> 
>  arch/arm/cpu/armv8/fsl-layerscape/soc.c            | 18 +++++-
>  arch/arm/include/asm/arch-fsl-layerscape/config.h  | 18 ++++++
>  .../include/asm/arch-fsl-layerscape/immap_lsch3.h  | 28 +++++++++
>  arch/arm/include/asm/fsl_secure_boot.h             | 50 ++++++++++++++--
>  board/freescale/common/cmd_esbc_validate.c         | 14 ++++-
>  board/freescale/common/fsl_validate.c              | 66 +++++++++++++++------
>  board/freescale/ls2080aqds/ls2080aqds.c            |  5 +-
>  board/freescale/ls2080ardb/ls2080ardb.c            |  5 +-
>  configs/ls2080aqds_SECURE_BOOT_defconfig           | 15 +++++
>  configs/ls2080ardb_SECURE_BOOT_defconfig           | 15 +++++
>  configs/ls2085aqds_SECURE_BOOT_defconfig           | 15 +++++
>  configs/ls2085ardb_SECURE_BOOT_defconfig           | 15 +++++
>  drivers/crypto/fsl/desc_constr.h                   |  7 +--
>  drivers/crypto/fsl/jr.c                            | 13 +++++
>  drivers/crypto/fsl/jr.h                            |  3 +
>  include/config_fsl_chain_trust.h                   | 25 +++++---
>  include/configs/ls2080aqds.h                       |  2 +
>  include/configs/ls2080ardb.h                       |  2 +
>  include/fsl_secboot_err.h                          |  3 +
>  include/fsl_sfp.h                                  |  3 +-
>  include/fsl_validate.h                             | 67 ++++++++++++++++++----
>  21 files changed, 341 insertions(+), 48 deletions(-)
>  create mode 100644 configs/ls2080aqds_SECURE_BOOT_defconfig
>  create mode 100644 configs/ls2080ardb_SECURE_BOOT_defconfig
>  create mode 100644 configs/ls2085aqds_SECURE_BOOT_defconfig
>  create mode 100644 configs/ls2085ardb_SECURE_BOOT_defconfig
> 

Saksham,

Please rebase your patches to the latest master branch. There is a change
73223f0e1bd0e37925ae1b7f21b51733145571dc got merged before I could merge your
patches. This change has great impact.

While you do that, I have some comments on some patches. Mostly the commit
message language and format.

York