[U-Boot] [PATCH] net: phy: Realtek RTL8211B/C PHY ID fix

Joe Hershberger joe.hershberger at gmail.com
Tue Mar 22 23:25:56 CET 2016


On Mon, Mar 21, 2016 at 2:29 PM, Karsten Merker <merker at debian.org> wrote:
> The RTL8211B_driver structure in drivers/net/phy/realtek.c contains a
> wrong PHY ID (0x1cc910 instead of 0x1cc912) in the uid field.
>
> The lowest four bits of the PHY ID encode the chip revision (B+C/D/E/F)
> of the RTL8211 and the code originally applied a mask of 0xfffff0 to
> the PHY ID, so that matching the PHY ID to the appropriate driver code
> was only done on the chip type (RTL8211), but not on a specific
> revision.
>
> After introduction of support for the RTL8211E, which needed another
> startup function than the older chip revisions, commit
> 42205047674d7fc9e0aa747273fbc7dcfbac3183 changed the mask to 0xffffff
> to make the chip revision relevant for the match, but didn't provide
> the now-relevant lower bits of the uid field for the RTL8211B/C.
>
> Fix this by setting the full PHY ID in the RTL8211B_driver uid field.
>
> Fixes: 42205047674d ("net/phy: realtek: Fix the PHY ID mask to ensure the correct Realtek PHY is detected")
> Signed-off-by: Karsten Merker <merker at debian.org>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list