[U-Boot] [PATCH v7 00/87] mtd: Add SPI-NOR core support

[Jagan Teki]

On 22 March 2016 at 20:25, Tom Rini <trini at konsulko.com> wrote:
> On Tue, Mar 22, 2016 at 01:19:25PM +0530, Jagan Teki wrote:
> [snip]
>> Issues:
>> -------
>> 1) undefined reference to `__aeabi_ldivmod'
>>
>> 59: config: Enable SPI-NOR framework
>>        arm:  +   nyan-big
>> +drivers/mtd/spi-nor/built-in.o: In function `spi_nor_write':
>> +build/../drivers/mtd/spi-nor/spi-nor.c:585: undefined reference to
>> `__aeabi_ldivmod'
>> +arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion
>> fail /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696
>> +arm-unknown-linux-gnueabi-ld.bfd: error: required section
>> '.rel.plt' not found in the linker script
>> +arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation
>> +make[1]: *** [u-boot] Error 1
>> +make: *** [sub-make] Error 2
>
> So this is a 64bit division problem somewhere along the lines that needs
> to be using one of the normal helper functions.
>
>> 2) Build issues on dra72_evm, dra74_evm
>
> What are they?

Build issue with spl, I guess this is because dm used for normal
u-boot and not used for spl.

Mugunthan, can you look in to this?

>
>> 3) SPL image too big
>>
>> 59: config: Enable SPI-NOR framework
>>        arm:  +   axm
>> +arm-unknown-linux-gnueabi-ld.bfd: SPL image too big
>> +arm-unknown-linux-gnueabi-ld.bfd: SPL image BSS too big
>> +make[2]: *** [spl/u-boot-spl] Error 1
>> +make[1]: *** [spl/u-boot-spl] Error 2
>> +make: *** [sub-make] Error 2
>
> Sounds like you need to go back and take some care about how we do this
> in SPL.  Given the current gcc issue wrt merging strings together, we
> may need to be more careful about what files we compile and link for SPL
> in this case and perhaps need to split a file or two up.

With proper commenting code for SPL build on mtdcore and changes on
SPL size macros, build look fine.

+++ b/include/configs/taurus.h
-#define CONFIG_SPL_MAX_SIZE            (31 * SZ_512)
+#define CONFIG_SPL_MAX_SIZE            (36 * SZ_512)
-#define CONFIG_SPL_BSS_MAX_SIZE                (3 * SZ_512)
+#define CONFIG_SPL_BSS_MAX_SIZE                (4 * SZ_512)

>
>> 60: spi-nor: Use CONFIG_MTD_SPI_NOR
>>
>>
>> Image size:
>> -----------
>> $> ./tools/buildman/buildman -b master -c 87 -sS
>
> Per commit is good for development but I really prefer to see the final
> totals, can you please report that too?  Thanks.

thanks!
-- 
Jagan.