[U-Boot] [PATCHv3 2/2] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Tom Warren]

Julian,

> -----Original Message-----
> From: Julian Scheel [mailto:julian at jusst.de]
> Sent: Wednesday, March 23, 2016 3:23 AM
> To: swarren at wwwdotorg.org; u-boot at lists.denx.de; Tom Warren
> <TWarren at nvidia.com>; Thierry Reding <treding at nvidia.com>
> Subject: Re: [PATCHv3 2/2] Add support the Avionic Design Meerkat COM and
> Kein Baseboard
> 
> On 04.03.2016 08:32, Julian Scheel wrote:
> > Add support for platforms based on the Meerkat COM module. Includes
> > support for the minimal reference platform called Kein Baseboard,
> > which in fact is sufficient to run most existing Meerkat carriers.
> >
> > Signed-off-by: Julian Scheel <julian at jusst.de>
> > ---
> > Changes in v3:
> >   - Remove bad as3722 gpio manipulations on pcie init (this time for
> > real)
> >
> > Changes in v2:
> >   - Rename config options to TARGET_KEIN_BASEBOARD
> >   - Remove unnecessary CONFIG options from kein-baseboard.h
> >   - Add clocks to meerkat dtsi, as it was removed from tegra124-dtsi
> > lately
> > ---
> 
> Are there any objections left on this series?
Applied this to u-boot-tegra/master, and it doesn't build for me (see kein-baseboard.ERR below).
No other Tegra board has CONFIG_FIT declared in its config.h file - move it to kein_defconfig?

Also, I noticed that your defconfig has:

CONFIG_RADOM_UUID=y

s/b 'RANDOM'_UUID

Please fix your patches to work against u-boot-tegra/master (I've just pushed a new copy that has been rebased against u-boot/master today).

Thanks,

Tom

$cat LOG/kein-baseboard.ERR

cmd/source.c: In function 'source':
cmd/source.c:100:3: warning: implicit declaration of function 'fit_check_format' [-Wimplicit-function-declaration]
cmd/source.c:106:3: warning: implicit declaration of function 'fit_image_get_node' [-Wimplicit-function-declaration]
cmd/source.c:112:3: warning: implicit declaration of function 'fit_image_check_type' [-Wimplicit-function-declaration]
cmd/source.c:119:4: warning: implicit declaration of function 'fit_image_verify' [-Wimplicit-function-declaration]
cmd/source.c:126:3: warning: implicit declaration of function 'fit_image_get_data' [-Wimplicit-function-declaration]
cmd/source.c: In function 'do_source':
cmd/source.c:157:2: warning: implicit declaration of function 'fit_parse_subimage' [-Wimplicit-function-declaration]
common/bootm_os.c: In function 'do_bootm_netbsd':
common/bootm_os.c:67:3: warning: implicit declaration of function 'fit_unsupported_reset' [-Wimplicit-function-declaration]
cmd/ximg.c: In function 'do_imgextract':
cmd/ximg.c:135:3: warning: implicit declaration of function 'fit_check_format' [-Wimplicit-function-declaration]
cmd/ximg.c:141:3: warning: implicit declaration of function 'fit_image_get_node' [-Wimplicit-function-declaration]
cmd/ximg.c:147:3: warning: implicit declaration of function 'fit_image_check_comp' [-Wimplicit-function-declaration]
cmd/ximg.c:157:4: warning: implicit declaration of function 'fit_image_verify' [-Wimplicit-function-declaration]
cmd/ximg.c:164:3: warning: implicit declaration of function 'fit_image_get_data' [-Wimplicit-function-declaration]
cmd/ximg.c:170:3: warning: implicit declaration of function 'fit_image_get_comp' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_get_debug':
common/image-fit.c:111:2: warning: implicit declaration of function 'fit_get_name' [-Wimplicit-function-declaration]
common/image-fit.c:111:2: warning: implicit declaration of function 'fdt_strerror' [-Wimplicit-function-declaration]
common/image-fit.c:111:2: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'int' [-Wformat]
common/image-fit.c:111:2: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'int' [-Wformat]
common/image-fit.c: In function 'fit_get_subimage_count':
common/image-fit.c:132:3: warning: implicit declaration of function 'fdt_next_node' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_print_contents':
common/image-fit.c:173:2: warning: implicit declaration of function 'fit_get_desc' [-Wimplicit-function-declaration]
common/image-fit.c:181:3: warning: implicit declaration of function 'fit_get_timestamp' [-Wimplicit-function-declaration]
common/image-fit.c:190:2: warning: implicit declaration of function 'fdt_path_offset' [-Wimplicit-function-declaration]
common/image-fit.c:193:10: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:208:11: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat]
common/image-fit.c:210:4: warning: implicit declaration of function 'fit_image_print' [-Wimplicit-function-declaration]
common/image-fit.c:217:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:223:2: warning: implicit declaration of function 'fdt_getprop' [-Wimplicit-function-declaration]
common/image-fit.c:238:11: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat]
common/image-fit.c:240:4: warning: implicit declaration of function 'fit_conf_print' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_image_print_data':
common/image-fit.c:270:2: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat]
common/image-fit.c:273:2: warning: implicit declaration of function 'fit_image_hash_get_algo' [-Wimplicit-function-declaration]
common/image-fit.c:278:10: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c:279:57: warning: comparison between pointer and integer [enabled by default]
common/image-fit.c:286:2: warning: implicit declaration of function 'fit_image_hash_get_value' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_image_print_verification_data':
common/image-fit.c:332:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: At top level:
common/image-fit.c:356:6: warning: conflicting types for 'fit_image_print' [enabled by default]
common/image-fit.c:210:4: note: previous implicit declaration of 'fit_image_print' was here
common/image-fit.c: In function 'fit_image_print':
common/image-fit.c:386:2: warning: implicit declaration of function 'fit_image_get_type' [-Wimplicit-function-declaration]
common/image-fit.c:389:2: warning: implicit declaration of function 'fit_image_get_comp' [-Wimplicit-function-declaration]
common/image-fit.c:392:2: warning: implicit declaration of function 'fit_image_get_data' [-Wimplicit-function-declaration]
common/image-fit.c:415:3: warning: implicit declaration of function 'fit_image_get_arch' [-Wimplicit-function-declaration]
common/image-fit.c:420:3: warning: implicit declaration of function 'fit_image_get_os' [-Wimplicit-function-declaration]
common/image-fit.c:426:3: warning: implicit declaration of function 'fit_image_get_load' [-Wimplicit-function-declaration]
common/image-fit.c:436:3: warning: implicit declaration of function 'fit_image_get_entry' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_get_timestamp':
common/image-fit.c:503:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_node':
common/image-fit.c:536:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:541:2: warning: implicit declaration of function 'fdt_subnode_offset' [-Wimplicit-function-declaration]
common/image-fit.c:543:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c: In function 'fit_image_get_os':
common/image-fit.c:570:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_arch':
common/image-fit.c:602:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_type':
common/image-fit.c:634:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_comp':
common/image-fit.c:666:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_address':
common/image-fit.c:682:2: error: unknown type name 'fdt32_t'
common/image-fit.c:685:7: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_image_get_data':
common/image-fit.c:766:8: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c: In function 'fit_get_end':
common/image-fit.c:864:2: warning: implicit declaration of function 'fdt_totalsize' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_set_timestamp':
common/image-fit.c:886:2: warning: implicit declaration of function 'fdt_setprop' [-Wimplicit-function-declaration]
common/image-fit.c:891:10: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:891:10: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat]
common/image-fit.c:892:18: error: 'FDT_ERR_NOSPACE' undeclared (first use in this function)
common/image-fit.c:892:18: note: each undeclared identifier is reported only once for each function it appears in
common/image-fit.c: In function 'calculate_hash':
common/image-fit.c:919:6: error: 'IMAGE_ENABLE_CRC32' undeclared (first use in this function)
common/image-fit.c:924:13: error: 'IMAGE_ENABLE_SHA1' undeclared (first use in this function)
common/image-fit.c:928:13: error: 'IMAGE_ENABLE_SHA256' undeclared (first use in this function)
common/image-fit.c:932:13: error: 'IMAGE_ENABLE_MD5' undeclared (first use in this function)
common/image-fit.c: In function 'fit_image_check_hash':
common/image-fit.c:945:16: error: 'HASH_MAX_DIGEST_SIZE' undeclared (first use in this function)
common/image-fit.c:945:10: warning: unused variable 'value' [-Wunused-variable]
common/image-fit.c: In function 'fit_image_verify':
common/image-fit.c:1019:6: error: 'IMAGE_ENABLE_VERIFY' undeclared (first use in this function)
common/image-fit.c:1020:6: warning: implicit declaration of function 'fit_image_verify_required_sigs' [-Wimplicit-function-declaration]
common/image-fit.c:1021:9: warning: implicit declaration of function 'gd_fdt_blob' [-Wimplicit-function-declaration]
common/image-fit.c:1027:2: warning: implicit declaration of function 'fdt_for_each_subnode' [-Wimplicit-function-declaration]
common/image-fit.c:1027:52: error: expected ';' before '{' token
common/image-fit.c:1070:9: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:1070:9: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat]
common/image-fit.c:1010:6: warning: unused variable 'ret' [-Wunused-variable]
common/image-fit.c: In function 'fit_all_image_verify':
common/image-fit.c:1096:10: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:1113:11: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c: In function 'fit_check_format':
common/image-fit.c:1228:47: warning: comparison between pointer and integer [enabled by default]
common/image-fit.c:1235:53: warning: comparison between pointer and integer [enabled by default]
common/image-fit.c: In function 'fit_conf_find_compat':
common/image-fit.c:1306:13: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c:1329:13: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c:1359:4: warning: implicit declaration of function 'fdt_node_check_compatible' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_conf_get_node':
common/image-fit.c:1402:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c:1422:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat]
common/image-fit.c: At top level:
common/image-fit.c:1455:6: warning: conflicting types for 'fit_conf_print' [enabled by default]
common/image-fit.c:240:4: note: previous implicit declaration of 'fit_conf_print' was here
common/image-fit.c: In function 'fit_conf_print':
common/image-fit.c:1488:7: warning: implicit declaration of function 'fdt_get_string_index' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'fit_get_node_from_config':
common/image-fit.c:1526:2: error: 'bootm_headers_t' has no member named 'fit_uname_cfg'
common/image-fit.c:1531:49: error: 'bootm_headers_t' has no member named 'fit_uname_cfg'
common/image-fit.c: In function 'fit_image_load':
common/image-fit.c:1616:7: error: 'IMAGE_ENABLE_BEST_MATCH' undeclared (first use in this function)
common/image-fit.c:1617:4: warning: passing argument 2 of 'fit_conf_find_compat' makes pointer from integer without a cast [enabled by default]
common/image-fit.c:1290:5: note: expected 'const void *' but argument is of type 'int'
common/image-fit.c:1628:3: warning: implicit declaration of function 'fdt_get_name' [-Wimplicit-function-declaration]
common/image-fit.c:1628:20: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c:1632:10: error: 'bootm_headers_t' has no member named 'fit_uname_cfg'
common/image-fit.c:1633:8: error: 'IMAGE_ENABLE_VERIFY' undeclared (first use in this function)
common/image-fit.c:1635:5: warning: implicit declaration of function 'fit_config_verify' [-Wimplicit-function-declaration]
common/image-fit.c:1648:13: warning: assignment makes pointer from integer without a cast [enabled by default]
common/image-fit.c:1666:2: warning: implicit declaration of function 'fit_image_check_target_arch' [-Wimplicit-function-declaration]
common/image-fit.c:1714:2: warning: implicit declaration of function 'fdt_check_header' [-Wimplicit-function-declaration]
common/image-fit.c:1751:3: warning: implicit declaration of function 'fit_get_size' [-Wimplicit-function-declaration]
common/image-fit.c: In function 'boot_get_setup_fit':
common/image-fit.c:1787:29: error: 'bootm_headers_t' has no member named 'fit_hdr_os'
common/image-fit.c: At top level:
common/image-fit.c:942:12: warning: 'fit_image_check_hash' defined but not used [-Wunused-function]
make[1]: *** [common/image-fit.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [common] Error 2
make: *** Waiting for unfinished jobs....
> 
> -Julian
--
nvpublic