[U-Boot] [RFC PATCH 1/2] net: phy: ti: Allow the driver to be more configurable

[Tom Rini]

On Thu, Mar 31, 2016 at 07:42:39AM -0500, Dan Murphy wrote:

> Not all devices use the same internal delay or fifo depth.
> Add the ability to set the internal delay for rx or tx and the
> fifo depth via the config file.  If the value is not set in the
> config file then set the delay to the default.
> 
> Signed-off-by: Dan Murphy <dmurphy at ti.com>
> ---
>  drivers/net/phy/ti.c                 | 71 ++++++++++++++++++++++++++++++++----
>  include/dt-bindings/net/ti-dp83867.h | 35 ++++++++++++++++++

I don't think this is taking things down the right path.  If it's a DT
binding, it comes from the device tree (which is fine and good!) but
that means the binding needs to meet the usual reviews and not just come
in via U-Boot like this.  We really don't want to add a DT binding that
gets values from the config.h file.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160331/09e84263/attachment.sig>