[U-Boot] [PATCH 09/12] cmd: qfw: workaround qfw build issue

[Tom Rini]

On Fri, May 13, 2016 at 10:00:37PM +0800, Bin Meng wrote:
> Hi Miao,
> 
> On Fri, May 13, 2016 at 2:29 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
> > The qfw command interface makes use of CONFIG_LOADADDR and
> > CONFIG_RAMDISKADDR to setup kernel. But not all boards have these macro,
> > which causes build problem on those platforms.
> >
> > This patch fixes this issue.
> >
> > Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
> 
> Looks good.
> 
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> 
> But the commit title "workaround" looks to be a workaround, which does
> not sound that good.

Yes, maybe just say that it's no longer requiring default values?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160513/abb6d20d/attachment.sig>