[U-Boot] [PATCH 09/12] cmd: qfw: workaround qfw build issue

[Miao Yan]

2016-05-14 4:46 GMT+08:00 Tom Rini <trini at konsulko.com>:
> On Fri, May 13, 2016 at 10:00:37PM +0800, Bin Meng wrote:
>> Hi Miao,
>>
>> On Fri, May 13, 2016 at 2:29 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>> > The qfw command interface makes use of CONFIG_LOADADDR and
>> > CONFIG_RAMDISKADDR to setup kernel. But not all boards have these macro,
>> > which causes build problem on those platforms.
>> >
>> > This patch fixes this issue.
>> >
>> > Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
>>
>> Looks good.
>>
>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> But the commit title "workaround" looks to be a workaround, which does
>> not sound that good.
>
> Yes, maybe just say that it's no longer requiring default values?

OK. Will fix.

Thanks,
Miao


>
> --
> Tom