[U-Boot] [PATCH v5 17/21] spi: Remove dual flash code

[Simon Glass]

Hi Jagan,

On 30 October 2016 at 11:46, Jagan Teki <jagan at openedev.com> wrote:
> Dual flash code in spi are usually take the spi controller
> to work with dual connected flash devices. Usually these
> dual connection operation's are referred to flash controller
> protocol rather with spi controller protocol, these are still
> present in flash side for the usage of spi-nor controllers.

That seems like good background information.

But after that you should write what this patch does. It seems like we
are missing the purpose of this patch, or are left to infer it.

>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: York Sun <york.sun at nxp.com>
> Cc: Vignesh R <vigneshr at ti.com>
> Cc: Mugunthan V N <mugunthanvnm at ti.com>
> Cc: Michal Simek <michal.simek at xilinx.com>
> Cc: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> Signed-off-by: Jagan Teki <jagan at openedev.com>
> ---
>  drivers/mtd/spi/sf.c        | 4 ----
>  drivers/mtd/spi/spi_flash.c | 1 -
>  include/spi.h               | 6 ------
>  3 files changed, 11 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

> diff --git a/drivers/mtd/spi/sf.c b/drivers/mtd/spi/sf.c
> index 664e860..d5e175c 100644
> --- a/drivers/mtd/spi/sf.c
> +++ b/drivers/mtd/spi/sf.c
> @@ -18,10 +18,6 @@ static int spi_flash_read_write(struct spi_slave *spi,
>         unsigned long flags = SPI_XFER_BEGIN;
>         int ret;
>
> -#ifdef CONFIG_SF_DUAL_FLASH
> -       if (spi->flags & SPI_XFER_U_PAGE)
> -               flags |= SPI_XFER_U_PAGE;
> -#endif
>         if (data_len == 0)
>                 flags |= SPI_XFER_END;
>
> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
> index b4001a5..708991c 100644
> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -1016,7 +1016,6 @@ int spi_flash_scan(struct spi_flash *flash)
>
>         flash->name = info->name;
>         flash->memory_map = spi->memory_map;
> -       flash->dual_flash = spi->option;
>
>         if (info->flags & SST_WR)
>                 flash->flags |= SNOR_F_SST_WR;
> diff --git a/include/spi.h b/include/spi.h
> index 4c17983..deb65ef 100644
> --- a/include/spi.h
> +++ b/include/spi.h
> @@ -30,10 +30,6 @@
>  #define SPI_RX_DUAL    BIT(12)                 /* receive with 2 wires */
>  #define SPI_RX_QUAD    BIT(13)                 /* receive with 4 wires */
>
> -/* SPI bus connection options - see enum spi_dual_flash */
> -#define SPI_CONN_DUAL_SHARED           (1 << 0)
> -#define SPI_CONN_DUAL_SEPARATED        (1 << 1)
> -
>  /* Header byte that marks the start of the message */
>  #define SPI_PREAMBLE_END_BYTE  0xec
>
> @@ -93,7 +89,6 @@ struct dm_spi_slave_platdata {
>   * @max_write_size:    If non-zero, the maximum number of bytes which can
>   *                     be written at once, excluding command bytes.
>   * @memory_map:                Address of read-only SPI flash access.
> - * @option:            Varies SPI bus options - separate, shared bus.
>   * @flags:             Indication of SPI flags.
>   */
>  struct spi_slave {
> @@ -117,7 +112,6 @@ struct spi_slave {
>  #define SPI_XFER_ONCE          (SPI_XFER_BEGIN | SPI_XFER_END)
>  #define SPI_XFER_MMAP          BIT(2)  /* Memory Mapped start */
>  #define SPI_XFER_MMAP_END      BIT(3)  /* Memory Mapped End */
> -#define SPI_XFER_U_PAGE                BIT(4)
>  };
>
>  /**
> --
> 2.7.4
>