[U-Boot] [PATCH] driver: net: fsl-mc: Use aligned address for MC FW load

[york sun]

On 11/09/2016 04:03 AM, Ashish Kumar wrote:
>>
>> Do you have substantial change beside the changing name from mc_ram_addr to mc_ram_aligned_base_addr?
>> [Ashish Kumar] It is not exactly name change. Here intent is to use userdefine memory size for MC  before this only 512MB of memory can be allocated to MC since it incorrectly used mc_ram_addr in place of mc_aligned_base_addr.
>> Ok, Name changes are there only in the function parameters to avoid confusion and retain the function signatures.
>
> Actually your change is more confusing. Let us try another way, for example not changing the name, shall we?
> [Ashish Kumar] If we do not rename function params "mc_ram_addr" to this "mc_ram_aligned_base_addr", we will be actually using aligned_base_addr but in function params  it will be denoted as mc_ram_addr will that be correct?
>

I think the only substantial change you have is in mc_init() function, 
where you moved the local variable mc_ram_aligned_base_addr to global. 
You started to use this global variable below and passed it as function 
parameters several times. For those passed as parameters, you don't need 
to rename them. If you take out those, you don't have to reformat the 
line wrap. So most of your changes can be avoided. Try that, you will 
have very small change and easy to review. Maybe you can find a better 
way to deal with alignment.

York