[U-Boot] [PATCH] drivers: SPI: sunxi SPL: fix warning

Andre Przywara andre.przywara at arm.com
Mon Nov 14 17:47:26 CET 2016


Hi,

On 14/11/16 16:30, Jagan Teki wrote:
> On Thu, Nov 3, 2016 at 6:28 AM, Andre Przywara <andre.przywara at arm.com> wrote:
>> Somehow an int returning function without a return statement sneaked
>> in. Fix it.
>>
>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>> ---
>>  drivers/mtd/spi/sunxi_spi_spl.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi/sunxi_spi_spl.c b/drivers/mtd/spi/sunxi_spi_spl.c
>> index 67c7edd..7502314 100644
>> --- a/drivers/mtd/spi/sunxi_spi_spl.c
>> +++ b/drivers/mtd/spi/sunxi_spi_spl.c
>> @@ -158,9 +158,10 @@ static void spi0_disable_clock(void)
>>                              (1 << AHB_RESET_SPI0_SHIFT));
>>  }
>>
>> -static int spi0_init(void)
>> +static void spi0_init(void)
>>  {
>>         unsigned int pin_function = SUNXI_GPC_SPI0;
>> +
> 
> Space not needed or unrelated, please  remove this.

This is Linux coding style, which U-Boot adheres to.
"WARNING: Missing a blank line after declarations"

I thought I should fix this since this is was in the context of this
very simple patch and it improves readability.
If this is too much, then please remove the line before committing.

Thanks!
Andre.


More information about the U-Boot mailing list