[U-Boot] [PATCH] splash: fix splash source flags check
Tomas Melin
tomas.melin at vaisala.com
Wed Nov 16 12:02:32 CET 2016
SPLASH_STORAGE_RAW is defined as 0, so a check against & will
never be true. These flags are never combined so do a check
against == instead.
Signed-off-by: Tomas Melin <tomas.melin at vaisala.com>
---
common/splash_source.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/common/splash_source.c b/common/splash_source.c
index 230b2db..72df2c1 100644
--- a/common/splash_source.c
+++ b/common/splash_source.c
@@ -327,10 +327,9 @@ int splash_source_load(struct splash_location *locations, uint size)
if (!splash_location)
return -EINVAL;
- if (splash_location->flags & SPLASH_STORAGE_RAW)
+ if (splash_location->flags == SPLASH_STORAGE_RAW)
return splash_load_raw(splash_location, bmp_load_addr);
- else if (splash_location->flags & SPLASH_STORAGE_FS)
+ else if (splash_location->flags == SPLASH_STORAGE_FS)
return splash_load_fs(splash_location, bmp_load_addr);
-
return -EINVAL;
}
--
2.1.4
More information about the U-Boot
mailing list