[U-Boot] [PATCH v6 0/6] LS2080ARDB: Enable EFI boot support

[york sun]

On 11/16/2016 02:22 PM, Alexander Graf wrote:
>
>
> On 16/11/2016 22:57, york sun wrote:
>> On 11/15/2016 02:20 PM, Alexander Graf wrote:
>>>
>>>
>>> On 15/11/2016 23:11, york sun wrote:
>>>>
>>>> On 11/15/2016 12:36 PM, Alexander Graf wrote:
>>>>> Hi York,
>>>>>
>>>>> Do you want to take that patch set?
>>>>>
>>>>
>>>> Yes, I can. I saw it assigned to you in patchwork so I didn't act.
>>>
>>> I think since it's really hardware enablement for your platform, I'd
>>> prefer if you pull them all in.
>>>
>>>
>>
>> Alex,
>>
>> I got compiling warnings
>
> Btw, speaking of warnings, you might want to compile the code base with
> gcc6 :)
>

I am not ready to move on to gcc6 yet. I have see a patch set floating 
in the mailing list, dealing with a lot of interesting found by gcc6.


> drivers/ddr/fsl/options.c:80:33: warning: 'single_S' defined but not
> used [-Wunused-const-variable=]
>   static const struct dynamic_odt single_S[4] = {
>                                   ^~~~~~~~
> drivers/ddr/fsl/options.c:63:33: warning: 'single_D' defined but not
> used [-Wunused-const-variable=]
>   static const struct dynamic_odt single_D[4] = {
>                                   ^~~~~~~~
> drivers/ddr/fsl/options.c:36:33: warning: 'single_Q' defined but not
> used [-Wunused-const-variable=]
>   static const struct dynamic_odt single_Q[4] = {
>                                   ^~~~~~~~
> drivers/net/e1000.c: In function 'e1000_initialize_hardware_bits':
> drivers/net/e1000.c:1526:2: warning: this 'if' clause does not guard...
> [-Wmisleading-indentation]
>    if (hw->mac_type == e1000_igb)
>    ^~
> drivers/net/e1000.c:1529:3: note: ...this statement, but the latter is
> misleadingly indented as if it is guarded by the 'if'
>     switch (hw->mac_type) {
>     ^~~~~~
>
> drivers/net/ldpaa_eth/ldpaa_eth.c: In function 'ldpaa_eth_open':
> drivers/net/ldpaa_eth/ldpaa_eth.c:423:2: warning: this 'if' clause does
> not guard... [-Wmisleading-indentation]
>    if (priv->phydev)
>    ^~
> drivers/net/ldpaa_eth/ldpaa_eth.c:425:3: note: ...this statement, but
> the latter is misleadingly indented as if it is guarded by the 'if'
>     if (err) {
>     ^~
>
>
> I'm seeing the warnings too now with the nand target. I'll fix them up
> and send v7.

Thanks.

York