[U-Boot] [PATCH] usb: xhci-mvebu: use xhci_deregister() for .remove callback

Marek Vasut marex at denx.de
Sun Oct 16 18:06:57 CEST 2016


On 10/14/2016 03:30 AM, Masahiro Yamada wrote:
> No need to use a wrapper that is equivalent to xhci_deregister().
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> 
>  drivers/usb/host/xhci-mvebu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-mvebu.c b/drivers/usb/host/xhci-mvebu.c
> index 23c241a..46eb937 100644
> --- a/drivers/usb/host/xhci-mvebu.c
> +++ b/drivers/usb/host/xhci-mvebu.c
> @@ -56,11 +56,6 @@ static int xhci_usb_probe(struct udevice *dev)
>  	return xhci_register(dev, ctx->hcd, hcor);
>  }
>  
> -static int xhci_usb_remove(struct udevice *dev)
> -{
> -	return xhci_deregister(dev);
> -}
> -
>  static int xhci_usb_ofdata_to_platdata(struct udevice *dev)
>  {
>  	struct mvebu_xhci_platdata *plat = dev_get_platdata(dev);
> @@ -89,7 +84,7 @@ U_BOOT_DRIVER(usb_xhci) = {
>  	.of_match = xhci_usb_ids,
>  	.ofdata_to_platdata = xhci_usb_ofdata_to_platdata,
>  	.probe = xhci_usb_probe,
> -	.remove = xhci_usb_remove,
> +	.remove = xhci_deregister,
>  	.ops	= &xhci_usb_ops,
>  	.platdata_auto_alloc_size = sizeof(struct mvebu_xhci_platdata),
>  	.priv_auto_alloc_size = sizeof(struct mvebu_xhci),
> 

Nice, applied, thanks!

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list