[U-Boot] [U-Boot, v2, 3/4] board: sama5d2_xplained: Set 'ethaddr' got from AT24MAC

Tom Rini trini at konsulko.com
Mon Oct 17 00:03:11 CEST 2016


On Sun, Oct 16, 2016 at 11:42:01PM +0200, Andreas Bießmann wrote:
> Hi Wenyou,
> 
> On Tue, Sep 13, 2016 at 10:49:04AM +0800, Wenyou Yang wrote:
> > If 'ethaddr' is not set, we will get the ethernet address from AT24MAC,
> > and set it to 'ethaddr' variable.
> > 
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > Signed-off-by: Songjun Wu <songjun.wu at microchip.com>
> > Reviewed-by: Andreas Bießmann <andreas at biessmann.org>
> > ---
> > 
> > Changes in v2: None
> > 
> >  board/atmel/sama5d2_xplained/sama5d2_xplained.c | 51 +++++++++++++++++++++++++
> >  include/configs/sama5d2_xplained.h              |  6 +++
> >  2 files changed, 57 insertions(+)
> > 
> 
> <snip>
> 
> > diff --git a/include/configs/sama5d2_xplained.h b/include/configs/sama5d2_xplained.h
> > index 77757a3..cada04f 100644
> > --- a/include/configs/sama5d2_xplained.h
> > +++ b/include/configs/sama5d2_xplained.h
> > @@ -15,6 +15,8 @@
> >  
> >  #include "at91-sama5_common.h"
> >  
> > +#define CONFIG_MISC_INIT_R
> > +
> >  /* SDRAM */
> >  #define CONFIG_NR_DRAM_BANKS		1
> >  #define CONFIG_SYS_SDRAM_BASE           ATMEL_BASE_DDRCS
> > @@ -54,6 +56,10 @@
> >  #define CONFIG_DOS_PARTITION
> >  #endif
> >  
> > +/* I2C */
> > +#define CONFIG_AT24MAC_ADDR		0x5c
> > +#define CONFIG_AT24MAC_REG		0x9a
> 
> these two configs produce compile warnings due to the lately introduced check
> for new config options outside Kconfig.
> 
> Please resend with these two options moved to Kconfig of sama5d2_xplained
> board.

Or just not in CONFIG namespace if there's really no reason for them to
be changed / selected.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161016/e3a5077e/attachment.sig>


More information about the U-Boot mailing list