[U-Boot] [U-Boot, 1/2] drivers: USB: OHCI: allow compilation for 64-bit targets

Marek Vasut marex at denx.de
Sun Oct 30 13:07:32 CET 2016


On 10/30/2016 10:51 AM, André Przywara wrote:
> On 29/10/16 18:42, Marek Vasut wrote:
>> On 10/29/2016 02:50 PM, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 21-10-16 03:24, Andre Przywara wrote:
>>>> OHCI has a known limitation of allowing only 32-bit DMA buffer
>>>> addresses, so we have a lot of u32 variables around, which are assigned
>>>> to pointers and vice versa. This obviously creates issues with 64-bit
>>>> systems, so the compiler complains here and there.
>>>> To allow compilation for 64-bit boards which use only memory below 4GB
>>>> anyway (and to avoid more invasive fixes), adjust some casts and types
>>>> and assume that the EDs and TDs are all located in the lower 4GB.
>>>> This fixes compilation of the OHCI driver for the Pine64.
>>>>
>>>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>>>
>>> Patch looks good to me:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede at redhat.com>
>>
>> Applied, thanks.
>>
>> Andre, it would be nice if you CC'd me on the original submission.
> 
> Yeah, sorry about that. I think I had you in To: on my --dry-run test,
> but somehow managed to drop you after fixing "just one more thing".
> 
> Thanks for applying this!

np, PR is out too.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list