[U-Boot] [PATCH v2 0/4] Migrate Vybrid USB driver to driver model

[Simon Glass]

Hi,

On 1 September 2016 at 03:49,  <maitysanchayan at gmail.com> wrote:
> On 16-08-23 15:17:12, Marek Vasut wrote:
>> On 08/09/2016 08:14 PM, Sanchayan Maity wrote:
>> > Hello,
>> >
>> > This is the second version of the patchset for migrating Vybrid
>> > USB driver to driver model.
>> >
>> > Compare to the first version, this version takes care of dr_mode
>> > property and correctly handles OTG as well when gpio is specified
>> > for use as ID detection pin. This is an essential requirement for
>> > OTG as Vybrid USB controller is not a true OTG though it can be
>> > configured as either host or device. The ID pin which is unique
>> > for OTG operation is not present on Vybrid.
>> >
>> > The problem with client that I was observing was related to sequence
>> > numbers. While trying to implement the OTG functionality I observed
>> > that if during probe of USB0 if it returns ENODEV, the probe of USB1
>> > provides a sequence number of 0 while we expect 1. The code relies
>> > on sequence numbers for initialising the appropriate peripherals.
>> > I use the bind operation to force a sequence number. This also seems
>> > to solve the problems I was having with USB client and mentioned
>> > in the previous version of the patchset.
>> >
>> > Host and client functionality are both functional with this patch.
>> > Patch series is based on top of latest u-boot master at the moment
>> > of this writing. Tested on Toradex Colibri Vybrid VF61 module.
>> >
>> > Thanks to Lukasz and Stefan for their comments.
>> >
>> > V1 Patches:
>> > [1].
>> > https://patchwork.ozlabs.org/patch/655370/
>> > [2].
>> > https://patchwork.ozlabs.org/patch/655371/
>> > [3].
>> > https://patchwork.ozlabs.org/patch/655372/
>> > [4].
>> > https://patchwork.ozlabs.org/patch/655373/
>> >
>> > Sanchayan Maity (4):
>> >   usb: host: ehci-vf: Migrate Vybrid USB to driver model
>> >   ARM: dts: vf: Add device tree node for USB on Vybrid
>> >   ARM: dts: vf-colibri: Enable USB device tree node for Colibri Vybrid
>> >   configs: colibri_vf_defconfig: Enable USB driver model for Colibri Vybrid
>> >
>> >  arch/arm/dts/vf-colibri.dtsi |  11 +++
>> >  arch/arm/dts/vf.dtsi         |  14 +++
>> >  configs/colibri_vf_defconfig |   1 +
>> >  drivers/usb/host/ehci-vf.c   | 208 +++++++++++++++++++++++++++++++++++++++++--
>> >  4 files changed, 227 insertions(+), 7 deletions(-)
>> >
>>
>> Looks OK to me, Simon, since this is DM, can you review it ?
>>
>
> Hello Simon,
>
> Do you think the patchset is ok?

Yes I think so.

Regards,
Simon