[U-Boot] [PATCH] Increase default of CONFIG_SYS_MALLOC_F_LEN for SPL_OF_CONTROL

Marek Vasut marex at denx.de
Tue Sep 6 14:27:11 CEST 2016


On 09/06/2016 02:24 PM, Masahiro Yamada wrote:
> 2016-09-06 10:04 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> On 30 August 2016 at 03:56, Stefan Roese <sr at denx.de> wrote:
>>> On 30.08.2016 11:50, Masahiro Yamada wrote:
>>>>
>>>> If both SPL_DM and SPL_OF_CONTROL are enabled, SPL needs to bind
>>>> several devices, but CONFIG_SYS_MALLOC_F_LEN=0x400 is apparently
>>>> not enough.  Increase the default to 0x2000 for the case.  This
>>>> will be helpful for shorter defconfigs.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>>>
>>>
>>> Reviewed-by: Stefan Roese <sr at denx.de>
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> It would be worth checking why. I fixed a bug where simple-bus would
>> bring in all devices regardless of the u-boot,dm-pre-reloc flag.
>> Perhaps that was it?
> 
> I do not think so.
> 
> Recently I tested this.  In spite of "u-boot,dm-pre-reloc"
> in the SPL device tree, my board failed in SPL.
> 
> I guess CONFIG_SYS_MALLOC_F_LEN=0x400 is not enough
> for binding/probing UART, pinctrl, MMC in SPL.
> 
> I increased the malloc size and it worked fine.

You can check this by tracking the allocations and the utilization of
the malloc space.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list