[U-Boot] [PATCH v3 7/8] arch, board: squash lines for immediate return

Minkyu Kang promsoft at gmail.com
Tue Sep 6 18:37:44 CEST 2016


On 6 September 2016 at 22:17, Masahiro Yamada <yamada.masahiro at socionext.com
> wrote:

> Remove unneeded variables and assignments.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
> Changes in v3:
>   - More fixes
>
>  arch/arm/cpu/arm920t/imx/timer.c              |  6 +-----
>  arch/arm/cpu/armv7/am33xx/sys_info.c          |  4 +---
>  arch/arm/cpu/sa1100/timer.c                   |  5 +----
>  arch/arm/mach-zynq/cpu.c                      |  8 ++------
>  arch/blackfin/cpu/interrupts.c                |  5 +----
>  arch/m68k/lib/time.c                          |  4 +---
>  arch/powerpc/cpu/mpc512x/cpu.c                |  6 +-----
>  arch/powerpc/cpu/mpc83xx/cpu.c                |  6 +-----
>  arch/xtensa/lib/time.c                        |  5 +----
>  board/amcc/bamboo/bamboo.c                    |  6 +-----
>  board/amcc/bubinga/bubinga.c                  |  5 +----
>  board/amcc/canyonlands/canyonlands.c          |  6 +-----
>  board/corscience/tricorder/tricorder-eeprom.c | 20 +++++---------------
>  board/freescale/common/zm7300.c               |  4 +---
>  board/samsung/goni/goni.c                     |  8 +-------
>  board/ti/omap5_uevm/evm.c                     |  5 +----
>  16 files changed, 21 insertions(+), 82 deletions(-)
>
> diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c
> index 1600568..e8329bb 100644
> --- a/board/samsung/goni/goni.c
> +++ b/board/samsung/goni/goni.c
> @@ -45,17 +45,11 @@ void i2c_init_board(void)
>
>  int power_init_board(void)
>  {
> -       int ret;
> -
>         /*
>          * For PMIC the I2C bus is named as I2C5, but it is connected
>          * to logical I2C adapter 0
>          */
> -       ret = pmic_init(I2C_0);
> -       if (ret)
> -               return ret;
> -
> -       return 0;
> +       return pmic_init(I2C_0);
>  }
>
>  int dram_init(void)
>

Reviewed-by: Minkyu Kang <mk7.kang at samsung.com>

Thanks,
Minkyu Kang.
-- 
from. prom.


More information about the U-Boot mailing list