[U-Boot] [PATCHv5 1/4] Revert "tegra: Add support for setting up a as3722 PMIC"

Stephen Warren swarren at wwwdotorg.org
Tue Sep 6 20:49:31 CEST 2016


On 09/06/2016 12:04 PM, Julian Scheel wrote:
> On 06.09.16 18:50, Stephen Warren wrote:
>> On 09/05/2016 07:29 AM, Julian Scheel wrote:
>>> This reverts commit 346451b5888c4663bccef4c5203357319aa41f99.
>>> The pmic shall be initialised in board specific code, as it is done for
>>> jetson-tk1 and meerkat. It can't be assumed that all boards have the
>>> pmic on
>>> the same i2c bus.
>>
>> You can't just revert this, since boards such as nyan-big and venice2
>> rely on this function being called. Admittedly jetson-tk1 does call this
>> a second time right now, but none of the other boards appear to.
>
> Sorry, I missed to adapt the other boards. I don't see another way than
> having this in each of the boards, as parameters might change, do you?

You can also parametrize the common code; either make it use #defines 
for the bus/device/... number and set those defines in a board-specific 
location, or call functions to retrieve that data which boards need to 
implement in a board-specific location.


More information about the U-Boot mailing list