[U-Boot] [PATCHv5 4/4] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Stephen Warren]

On 09/05/2016 07:29 AM, Julian Scheel wrote:
> Add support for platforms based on the Meerkat COM module. Includes support
> for the minimal reference platform called Kein Baseboard, which in fact is
> sufficient to run most existing Meerkat carriers.

> diff --git a/board/avionic-design/common/meerkat.c b/board/avionic-design/common/meerkat.c

> +int tegra_pcie_board_init(void)

> +	err = as3722_init(&pmic, 4, 0x40);

Thinking about this more: Why I2C bus 4 not 0? All other boards set up 
the PMIC I2C bus to be I2C bus 0 in U-Boot's numbering scheme. I'm not 
sure we should deviate from that since it will provide users (running 
the i2c command at the U-Boot shell) with an inconsistent experience.

Also, 0x40 is the I2C address that's used before this series, so I don't 
think there's a need to pass the value in as a parameter since all 
boards use the same value. In fact, that value is part of the AS3722 HW 
itself, so I'm not sure that it could actually vary, unless there are 
address strapping pins on the chip. Even if so, it seems a bit unlikely 
someone would actually use them to select a non-default address, at 
least in situations likely to be encountered on any Tegra board.