[U-Boot] [PATCHv5 4/4] Add support the Avionic Design Meerkat COM and Kein Baseboard

[Stephen Warren]

On 09/07/2016 12:03 AM, Julian Scheel wrote:
> On 06.09.2016 20:53, Stephen Warren wrote:
>> On 09/05/2016 07:29 AM, Julian Scheel wrote:
>>> Add support for platforms based on the Meerkat COM module. Includes
>>> support
>>> for the minimal reference platform called Kein Baseboard, which in
>>> fact is
>>> sufficient to run most existing Meerkat carriers.
>>
>>> diff --git a/board/avionic-design/common/meerkat.c
>>> b/board/avionic-design/common/meerkat.c
>>
>>> +int tegra_pcie_board_init(void)
>>
>>> +    err = as3722_init(&pmic, 4, 0x40);
>>
>> Thinking about this more: Why I2C bus 4 not 0? All other boards set up
>> the PMIC I2C bus to be I2C bus 0 in U-Boot's numbering scheme. I'm not
>> sure we should deviate from that since it will provide users (running
>> the i2c command at the U-Boot shell) with an inconsistent experience.
>
> Please see the discussion from earlier this year, when I initially sent
> this patches:
> http://lists.denx.de/pipermail/u-boot/2016-February/246952.html
>
> Still if you're too unhappy about it now we would change it, but if not
> we'd rather keep it that way. Having a user being confused because of
> different mapping in our l4t kernel and uboot seems to be more likely
> than a user being confused because of different mappings on different
> boards to me.

OK, I guess that's fine. As I mentioned before, let's make sure there 
are aliases for the I2C controllers in the kernel DT file - otherwise, 
there's no guarantee of a particular ordering of I2C adapter IDs.