[U-Boot] [PATCH] sunxi: musb: Power off OTG port VBUS when disabled

Ian Campbell ijc at hellion.org.uk
Thu Sep 8 14:04:07 CEST 2016


On Wed, 2016-09-07 at 14:25 +0800, Chen-Yu Tsai wrote:
> The Linux kernel musb driver expects...

I don't much like this line of reasoning/explanation for changes to u-
boot. I appreciate that it might seem like all the world is Linux
(especially in sunxi context) but the right way to descibe these
changes IMHO is "A sensible behaviour for firmware is to ... because
..." i.e. to consider the general case.

Otherwise I might be tempted to say things like...

>  VBUS to be off while initializing
> musb. Having it on results in a repeating string of warnings, followed
> > by an unusable peripheral.

... this sounds like it might be a Linux bug, perhaps it should be
fixed there?

Ian.


More information about the U-Boot mailing list