[U-Boot] [PATCH] usb: gadget: ci_udc: fix suspend/resume of USB Mass Storage

John Tobias john.tobias.ph at gmail.com
Thu Sep 8 16:42:19 CEST 2016


Hi Fabio,

On Thu, Sep 8, 2016 at 4:05 AM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi John,
>
> On Wed, Aug 24, 2016 at 2:25 AM, John Tobias <john.tobias.ph at gmail.com> wrote:
>
>> I tried to following combinations below but, the return
>> SETUP(r.bRequestType, r.bRequest) doesn't match at all.
>>
>> SETUP(USB_DIR_IN | USB_RECIP_DEVICE, USB_REQ_GET_STATUS)
>> SETUP(USB_RECIP_DEVICE, USB_REQ_GET_STATUS)
>> SETUP(USB_DIR_IN, USB_REQ_GET_STATUS)
>>
>>> I don't think it's correct to remove the bRequestType checking altogether.
>>
>> Looking at the fsl_udc_core.c
>> http://lxr.free-electrons.com/source/drivers/usb/gadget/udc/fsl_udc_core.c#L1405
>> looks identical.
>
> This is the old udc driver for the non-dt imx.
>
> Currently we use drivers/usb/chipidea/udc.c, which also seems to match
> what you do in your patch.
>
> Regards,
>
> Fabio Estevam

Thanks for the info and clarification.

Btw, any updates with this patch?.

Regards,

John


More information about the U-Boot mailing list